Do we need a FastPointFunc and LoosePointFunc? #5237
Replies: 5 comments
-
Yeah, I think this is quite confusing, if we can remove them that would be ideal. |
Beta Was this translation helpful? Give feedback.
-
We could start deprecating warnings for args and kwargs in V3 and remove the LoosePointFunc in V4 |
Beta Was this translation helpful? Give feedback.
-
More importantly, these properties/methods always compile a new aesara function which is quite slow if one wants to evaluate a model many times. We might want to rename them to something like Similarly to how we have |
Beta Was this translation helpful? Give feedback.
-
This is done, right? |
Beta Was this translation helpful? Give feedback.
-
No, but we can open an issue |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
It seems that the difference is that
LoosePointFunc
allows you to evaluate alogp
/dlogp
/ what have you with args and kwargs, instead of just passing a dictionary, but at the cost of being slower because it has to wrap them in a dictionary (Point) before calling logp.Does anyone actually use this? Should the default be the "fast" version that only accepts a dictionary, and the flexible one be called something like "slow"? Do we even need the slow version?
pymc/pymc/model.py
Lines 1722 to 1766 in f6f1a8e
Beta Was this translation helpful? Give feedback.
All reactions