Mirror codebase structure in tests #5579
Replies: 2 comments
-
Yeah, that makes a lot more sense. |
Beta Was this translation helpful? Give feedback.
-
Related, here's a PR to combine the workflows into one: #5623 Because our tests take so much time, it doesn't make sense to run a dense matrix in the workflows. Our current one is already sparse: But the definition in YAML is a little clumsy, with some things parametrized via the EDIT: After learning that line breaks in the |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I think the tests files should mirror the original codebase. So they should be in a file with the same name as where the functions/classes that it tests are defined. E.g.,, timeseries tests should be in tests/distributions/test_timeseries.py. This is how Aesara does it and its much easier to find what tests relate to what code, and also to spot gaps in our tests.
Originally posted by @ricardoV94 in #5298 (comment)
This would also allow to break up the immensely large and slow
test_distributions.py
, which was already brought up in #5410 (comment)Also, #5577 (comment)
Beta Was this translation helpful? Give feedback.
All reactions