Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add cmd.FullName in metrics attributes #2872

Closed
2011aad opened this issue Jan 23, 2024 · 1 comment · May be fixed by #3050
Closed

Add cmd.FullName in metrics attributes #2872

2011aad opened this issue Jan 23, 2024 · 1 comment · May be fixed by #3050
Labels

Comments

@2011aad
Copy link

2011aad commented Jan 23, 2024

Issue tracker is used for reporting bugs and discussing new features. Please use
stackoverflow for supporting issues.

Adding a cmd name attribute is useful for monitoring application accessing redis, because different kinds of cmd may perform differently.

Expected Behavior

Expect adding cmd name (get/set/del etc.) in metrics attributes.

Current Behavior

Currently, only type:command attribute is added to the metrics.

Possible Implementation

Add the following code in ProcessHook function of metricsHook.

attrs = append(attrs, attribute.String("cmd", cmd.FullName()))

Copy link

This issue is marked stale. It will be closed in 30 days if it is not updated.

@github-actions github-actions bot added the Stale label Jan 23, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant