Some youtube/tv links not working #7

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Open

laggingreflex opened this issue Dec 19, 2016 · 3 comments

Labels

laggingreflex commented Dec 19, 2016 •

edited

Loading

It doesn't work on some youtube.com/tv links

Doesn't work: https://www.youtube.com/tv#/watch/video/idle?v=oNXzMBA9VU4&resume
Doesn't work: https://www.youtube.com/tv#/watch/video/idle?v=oNXzMBA9VU4
Doesn't work: https://www.youtube.com/tv#/watch/video/seek?v=oNXzMBA9VU4
Doesn't work: https://www.youtube.com/tv#/watch/video/control?v=oNXzMBA9VU4
Doesn't work: https://www.youtube.com/tv#/watch/video?v=oNXzMBA9VU4
Doesn't work: https://www.youtube.com/tv#/watch?v=c7GVeJJcD5w&list=UUFZO6aPugMrZjUOobX7IQDA
Works : https://www.youtube.com/tv#/watch?v=oNXzMBA9VU4

related: ytdl-org/youtube-dl#11485

The text was updated successfully, but these errors were encountered:

tunnckoCore added bug todo labels

Member

tunnckoCore commented Dec 19, 2016

Thanks for the report.

Member

tunnckoCore commented Dec 19, 2016 •

edited

Loading

It seems like a simple fix, but I'll investigate more later tonight.

edit: http://regexr.com/3etii - just with simple (?:.*), but that with /control fails (because we search for between 6 and 11, duh)

Member

tunnckoCore commented Jul 14, 2017 •

edited by ghost

Loading

Simplest and fastest fix currently is change from above and (?!control), so

const regex = /(?:youtube\.com\/\S*(?:(?:\/e(?:mbed))?\/|watch(?:.*)\?(?:\S*?&?v\=))|youtu\.be\/)((?!control)[a-zA-Z0-9_-]{6,11})/;

http://regexr.com/3gbp9

# for free to join this conversation on GitHub. Already have an account? # to comment