Skip to content
This repository was archived by the owner on Feb 16, 2022. It is now read-only.

Attributable::relationsToArray() doesn't return entity attributes #165

Open
rneal-ck opened this issue Jan 4, 2022 · 0 comments · May be fixed by #166
Open

Attributable::relationsToArray() doesn't return entity attributes #165

rneal-ck opened this issue Jan 4, 2022 · 0 comments · May be fixed by #166

Comments

@rneal-ck
Copy link

rneal-ck commented Jan 4, 2022

In Attributable::relationsToArray(), the entity attributes for a model are only added to $eavAttributes if they exist in the array returned by parent::relationsToArray() (from HasAttributes), however, HasAttributes::relationsToArray doesn't know about the entity attributes, so the check always fails, causing the entity attributes to not be included when converting to JSON.
@rneal-ck rneal-ck changed the title Attributable::relationsToArray doesn't return entity attributes Attributable::relationsToArray() doesn't return entity attributes Jan 4, 2022
@rneal-ck rneal-ck linked a pull request Jan 4, 2022 that will close this issue
Open
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attributable::relationsToArray() doesn't return entity attributes rneal-ck/laravel-attributes
1 participant
@rneal-ck