Skip to content

Commit 7276091

Browse files
authoredFeb 14, 2025
Merge pull request #69 from ropensci/cran2
update example to remove warning from osmdata for #59
2 parents 0827a54 + c625fce commit 7276091

File tree

5 files changed

+13
-22
lines changed

5 files changed

+13
-22
lines changed
 

‎DESCRIPTION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: osmplotr
22
Title: Bespoke Images of 'OpenStreetMap' Data
3-
Version: 0.3.5.019
3+
Version: 0.3.5.021
44
Authors@R:
55
c(person(given = "Mark",
66
family = "Padgham",

‎R/make-osm-map.R

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@
4141
#' # 'london' data for highways and parks.
4242
#' dat <- make_osm_map (osm_data = london, structures = structs)
4343
#' # or download data automatically using a defined bounding boox
44-
#' bbox <- get_bbox (c (-0.15, 51.5, -0.10, 51.52))
45-
#' dat <- make_osm_map (bbox = bbox, structures = structs)
44+
#' bbox <- get_bbox (c (-0.14, 51.51, -0.12, 51.52))
4645
#' \donttest{
46+
#' dat <- make_osm_map (bbox = bbox, structures = structs)
4747
#' print_osm_map (dat$map)
4848
#' }
4949
#' @family construction

‎codemeta.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88
"codeRepository": "https://github.com/ropensci/osmplotr",
99
"issueTracker": "https://github.com/ropensci/osmplotr/issues",
1010
"license": "https://spdx.org/licenses/GPL-3.0",
11-
"version": "0.3.5.019",
11+
"version": "0.3.5.021",
1212
"programmingLanguage": {
1313
"@type": "ComputerLanguage",
1414
"name": "R",
1515
"url": "https://r-project.org"
1616
},
17-
"runtimePlatform": "R version 4.3.3 (2024-02-29)",
17+
"runtimePlatform": "R version 4.4.2 (2024-10-31)",
1818
"author": [
1919
{
2020
"@type": "Person",
@@ -269,12 +269,12 @@
269269
},
270270
"SystemRequirements": {}
271271
},
272-
"fileSize": "12101.377KB",
272+
"fileSize": "1371.45KB",
273273
"releaseNotes": "https://github.com/ropensci/osmplotr/blob/master/NEWS.md",
274274
"readme": "https://github.com/ropensci/osmplotr/blob/main/README.md",
275275
"contIntegration": [
276276
"https://github.com/ropensci/osmplotr/actions?query=workflow%3AR-CMD-check",
277-
"https://codecov.io/gh/ropensci/osmplotr"
277+
"https://app.codecov.io/gh/ropensci/osmplotr"
278278
],
279279
"developmentStatus": "https://www.repostatus.org/",
280280
"review": {

‎cran-comments.md

+4-13
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,18 @@
11
# CRAN notes for osmplotr_v0.3.6 re-submission
22

3-
This is a re-submission of a previously archived package. The submission may
4-
generate one single note regarding installed size of ~6MB, which is due to the
5-
vignettes. These produce many graphical files illustrating the package's
6-
functionality. Every effort has been made to reduce this as much as possible,
7-
including reducing the resolution of these images to the coarsest practicable
8-
scale. Halving the resolution again (from current 72 to 36 dpi) only decreases
9-
the final package size by around 200 kB.
3+
This is a re-submission of a previously archived package. The submission may generate one single note regarding installed size of ~6MB, which is due to the vignettes. These produce many graphical files illustrating the package's functionality. Every effort has been made to reduce this as much as possible, including reducing the resolution of these images to the coarsest practicable scale. Halving the resolution again (from current 72 to 36 dpi) only decreases the final package size by around 200 kB.
104

11-
This re-submission also rectifies several issues pointed out in an email from
12-
7th Feb 2025:
5+
This re-submission also rectifies several issues pointed out in an email from 7th Feb 2025:
136

147
- Return values have been documented in all functions
15-
- Most `\dontrun` statements have been reduced, and converted to `donttest`. A
16-
few nevertheless remain, as the example code makes external API calls to
17-
download data. The following functions retain `dontrun` statements only around
18-
code which makes external API calls:
8+
- Most `\dontrun` statements have been reduced, and converted to `donttest`. A few nevertheless remain, as the example code makes external API calls to download data. The following functions retain `dontrun` statements only around code which makes external API calls:
199
- `add_osm_groups()`
2010
- `adjust_colours()`,
2111
- `add_osm_objects()`
2212
- `extract_osm_objects()`
2313
- `osm_line2poly()`
2414
- `connect_highways()`.
15+
- All previous uses of `cat()` have been removed, and replaced with `message()`.
2516

2617

2718
## Test environments

‎man/make_osm_map.Rd

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)