Skip to content

Commit bc190a3

Browse files
authored
fix versioning + trailing junk error pgsql
Hotfix: fix versioning + trailing junk error
2 parents 9257302 + 14e7895 commit bc190a3

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 2025032500 v1.5.8
2+
* Hotfix: correct further trailing junk after parameter
3+
* Versioning error fix
4+
5+
16
## 2025031700 v1.5.8
27
* Correct Privacy API tests
38
* Iss129: remove print_error deprecated function

locallib.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -1024,15 +1024,15 @@ function pdfannotator_get_questions($courseid, $context, $questionfilter) {
10241024
. "JOIN {course_modules} cm ON p.id = cm.instance "
10251025
. "LEFT JOIN {pdfannotator_votes} v ON c.id=v.commentid "
10261026
. "LEFT JOIN {pdfannotator_comments} answ ON answ.annotationid = a.id "
1027-
. "WHERE c.isquestion = 1 AND p.course = ? AND cm.id $insql";
1027+
. "WHERE c.isquestion = 1 AND p.course = ? AND cm.id $insql ";
10281028
if ($questionfilter == 0) {
10291029
$sql = $sql . ' AND c.solved = 0 ';
10301030
}
10311031
if ($questionfilter == 1) {
10321032
$sql = $sql . ' AND NOT c.solved = 0 ';
10331033
}
1034-
$sql = $sql . "GROUP BY a.id, p.name, p.usevotes, cm.id, c.id, a.page, a.pdfannotatorid, c.content, c.userid, c.visibility,"
1035-
. "c.timecreated, c.isdeleted, c.ishidden, c.isquestion";
1034+
$sql = $sql . "GROUP BY a.id, p.name, p.usevotes, cm.id, c.id, a.page, a.pdfannotatorid, c.content, c.userid, c.visibility, "
1035+
. "c.timecreated, c.isdeleted, c.ishidden, c.isquestion ";
10361036
$params = array_merge([$courseid], $inparams);
10371037
$questions = $DB->get_records_sql($sql, $params);
10381038

@@ -1194,7 +1194,7 @@ function pdfannotator_get_answers_for_this_user($courseid, $context, $answerfilt
11941194

11951195
if ($answerfilter == 0) { // Either: get all answers in this annotator.
11961196
$sql = "SELECT c.id AS answerid, c.content AS answer, c.userid AS userid, c.visibility, "
1197-
. "c.timemodified, c.solved AS correct, c.ishidden AS answerhidden, a.id AS annoid, a.page, q.id AS questionid,"
1197+
. "c.timemodified, c.solved AS correct, c.ishidden AS answerhidden, a.id AS annoid, a.page, q.id AS questionid, "
11981198
. "q.userid AS questionuserid, c.isquestion, c.annotationid, "
11991199
. "q.visibility AS questionvisibility, "
12001200
. "q.content AS answeredquestion, q.isdeleted AS questiondeleted, q.ishidden AS questionhidden, p.id AS annotatorid, "

version.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
defined('MOODLE_INTERNAL') || die();
2626

2727
$plugin->component = 'mod_pdfannotator';
28-
$plugin->version = 2025031700;
28+
$plugin->version = 2025032500;
2929
$plugin->release = 'PDF Annotator v1.5 release 8';
3030
$plugin->requires = 2021051700;
3131
$plugin->maturity = MATURITY_STABLE;

0 commit comments

Comments
 (0)