Skip to content
This repository was archived by the owner on Sep 14, 2018. It is now read-only.

security panel needs symfony/yaml #90

Open
mathroc opened this issue May 7, 2016 · 3 comments
Open

security panel needs symfony/yaml #90

mathroc opened this issue May 7, 2016 · 3 comments

Comments

@mathroc
Copy link

mathroc commented May 7, 2016

the security panel does not work without the symfony/yaml package

I don't think it can be added to composer.json dependencies (unless symfony/security-bundle is also added)

maybe dump or var_dump can used when the Yaml class does not exists ?

@HeahDude
Copy link
Contributor

HeahDude commented May 7, 2016

Hi @mathroc, I'm actually not very happy with the hardcoding of the filter and function either.
The SecurityBundle only requires symfony/yaml in dev but needs them to dump collected data in the profiler panel.

I think we could use composer suggestion in SecurityBundle for both symfony/twig-bridge and symfony/yaml and suggest the symfony/security-bundle in this repo.
All these suggestions for using the data collector.

Any thought on how to improve that would be helpful, thanks!

@mathroc
Copy link
Author

mathroc commented May 7, 2016

maybe we could just require symfony/yaml and symfony/security-bundle here. it would install a few useless things sometimes but would have a the benefit of making everything works without intervention.

I would even go as far as adding every "optional" dependencies to silex/web-profiler as required dependencies and remove all class_exists from the WebProfilerServiceProvider.php.
I always find it annoying to manually composer require --dev those packages just to make the profiler work.

@ek9
Copy link

ek9 commented Feb 25, 2017

Perhaps a short-term solution would be to add a suggest with a note to install symfony/yaml too if you are using the security panel? The composer would pop that message only if the package is not installed.

fabpot added a commit that referenced this issue May 3, 2017
This PR was merged into the 2.0.x-dev branch.

Discussion
----------

Add info about security-bundle in the README

Along the lines of monolog-bridge and debug-bundle, the security-bundle is needed as a dependency to show security information panel in the toolbar. This change is to document that.

This should close #96.

Also this should be improved once #90 is resolved.

Commits
-------

5f031ff Add info about security-bundle in the README
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants