Skip to content

Serde JSON defaults don't match Default::default() #175

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
montanalow opened this issue Sep 26, 2022 · 0 comments
Open

Serde JSON defaults don't match Default::default() #175

montanalow opened this issue Sep 26, 2022 · 0 comments
Milestone

Comments

@montanalow
Copy link
Collaborator

By default, #[serde(default)] uses the default for the type, e.g. 0 for all numeric types, rather than the default for the structs field, e.g. 3 for KNNRegressor.k.

I will take up a fix to sync the JSON and Default values for all fields, as soon as we agree on a solution for #174. I believe the b option also makes this simpler as well.

@Mec-iS Mec-iS added this to the v0.5 milestone Oct 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants