RemoveUnused

Author: Vincent Potucek

.editorconfig

@@ -1,9 +1,10 @@
-[*]
+root = true
+
+[*.{adoc,bat,groovy,html,java,js,jsp,kt,kts,md,properties,py,rb,sh,sql,svg,txt,xml,xsd}]
 charset = utf-8
-end_of_line = lf
 
 [*.{groovy,java,kt,kts,xml,xsd}]
-ij_continuation_indent_size = 8
-indent_size = 4
 indent_style = tab
-max_line_length = 120
+indent_size = 4
+continuation_indent_size = 8
+end_of_line = lf

buildSrc/config/checkstyle/checkstyle.xml

@@ -20,7 +20,6 @@
 		<module name="RedundantImport"/>
 		<!-- Modifiers -->
 		<module name="com.puppycrawl.tools.checkstyle.checks.modifier.ModifierOrderCheck"/>
-		<!--		<module name="FinalLocalVariable"/>-->
 
 	</module>
 

framework-docs/src/main/java/org/springframework/docs/integration/cache/cachestoreconfigurationnoop/CacheConfiguration.java

@@ -26,6 +26,14 @@
 @Configuration
 class CacheConfiguration {
 
+	private CacheManager jdkCache() {
+		return null;
+	}
+
+	private CacheManager gemfireCache() {
+		return null;
+	}
+
 	// tag::snippet[]
 	@Bean
 	CacheManager cacheManager(CacheManager jdkCache, CacheManager gemfireCache) {

framework-docs/src/main/java/org/springframework/docs/testing/mockmvc/assertj/mockmvctestersetup/AccountControllerStandaloneTests.java

@@ -16,9 +16,13 @@
 
 package org.springframework.docs.testing.mockmvc.assertj.mockmvctestersetup;
 
+import org.springframework.test.web.servlet.assertj.MockMvcTester;
+
 // tag::snippet[]
 public class AccountControllerStandaloneTests {
 
+	private final MockMvcTester mockMvc = MockMvcTester.of(new AccountController());
+
 	// ...
 
 }

framework-docs/src/main/java/org/springframework/docs/web/webmvc/mvcconfig/mvcconfigpathmatching/WebConfiguration.java

@@ -5,6 +5,7 @@
 import org.springframework.web.method.HandlerTypePredicate;
 import org.springframework.web.servlet.config.annotation.PathMatchConfigurer;
 import org.springframework.web.servlet.config.annotation.WebMvcConfigurer;
+import org.springframework.web.util.pattern.PathPatternParser;
 
 // tag::snippet[]
 @Configuration
@@ -14,5 +15,11 @@ public class WebConfiguration implements WebMvcConfigurer {
 	public void configurePathMatch(PathMatchConfigurer configurer) {
 		configurer.addPathPrefix("/api", HandlerTypePredicate.forAnnotation(RestController.class));
 	}
+
+	private PathPatternParser patternParser() {
+		PathPatternParser pathPatternParser = new PathPatternParser();
+		// ...
+		return pathPatternParser;
+	}
 }
 // end::snippet[]

import-into-eclipse.md

@@ -48,8 +48,7 @@ _When instructed to execute `./gradlew` from the command line, be sure to execut
 1. While JUnit tests pass from the command line with Gradle, some may fail when run from
    the IDE.
    - Resolving this is a work in progress.
-   - If attempting to run all JUnit tests from within the IDE, you may need to set the following VM options to avoid out
-     of memory errors: `-XX:MaxPermSize=2g -Xmx2g -XX:MaxHeapSize=2g`
+   - If attempting to run all JUnit tests from within the IDE, you may need to set the following VM options to avoid out of memory errors: `-XX:MaxPermSize=2048m -Xmx2048m -XX:MaxHeapSize=2048m`
 
 ## Tips
 

import-into-idea.md

@@ -19,7 +19,7 @@ IntelliJ IDEA. See https://youtrack.jetbrains.com/issue/IDEA-64446 for details.
 3. While JUnit tests pass from the command line with Gradle, some may fail when run from
 IntelliJ IDEA. Resolving this is a work in progress. If attempting to run all JUnit tests from within
 IntelliJ IDEA, you will likely need to set the following VM options to avoid out of memory errors:
-   -XX:MaxPermSize=2g -Xmx2g -XX:MaxHeapSize=2g
+    -XX:MaxPermSize=2048m -Xmx2048m -XX:MaxHeapSize=2048m
 4. If you invoke "Rebuild Project" in the IDE, you'll have to generate some test
 resources of the `spring-oxm` module again (`./gradlew :spring-oxm:compileTestJava`)    
 

integration-tests/src/test/java/org/springframework/aot/test/SampleReflection.java

@@ -26,11 +26,13 @@ public class SampleReflection {
 
 	@SuppressWarnings("unused")
 	public void sample() {
+		String value = "Sample";
 		Method[] methods = String.class.getMethods();
 	}
 
 	@SuppressWarnings("unused")
 	public void multipleCalls() {
+		String value = "Sample";
 		Method[] methods = String.class.getMethods();
 		methods = Integer.class.getMethods();
 	}

spring-aop/src/test/java/org/springframework/aop/aspectj/annotation/AspectJAdvisorBeanRegistrationAotProcessorTests.java

@@ -74,9 +74,11 @@ void process(Class<?> beanClass) {
 
 
 	static class AspectJClass {
+		private static java.lang.Throwable ajc$initFailureCause;
 	}
 
 	static class RegularClass {
+		private static java.lang.Throwable initFailureCause;
 	}
 
 }

spring-beans/src/test/java/org/springframework/beans/PropertyMatchesTests.java

@@ -183,6 +183,16 @@ public void setCounter3(int counter3) {
 	@SuppressWarnings("unused")
 	private static class SampleFieldProperties {
 
+		private String name;
+
+		private String description;
+
+		private int counter1;
+
+		private int counter2;
+
+		private int counter3;
+
 	}
 
 }

spring-beans/src/test/java/org/springframework/beans/factory/support/QualifierAnnotationAutowireBeanFactoryTests.java

@@ -257,6 +257,8 @@ private static class QualifiedTestBean {
 		@TestQualifier
 		private Person qualified;
 
+		private Person nonqualified;
+
 		public QualifiedTestBean(@TestQualifier Person tpb) {
 		}
 

spring-context/src/main/java/org/springframework/scripting/support/StandardScriptFactory.java

@@ -20,6 +20,7 @@
 import java.lang.reflect.InvocationTargetException;
 
 import javax.script.Invocable;
+import javax.script.ScriptEngine;
 import javax.script.ScriptEngineManager;
 
 import org.jspecify.annotations.Nullable;
@@ -49,8 +50,16 @@
  */
 public class StandardScriptFactory implements ScriptFactory, BeanClassLoaderAware {
 
+	private final @Nullable String scriptEngineName;
+
 	private final String scriptSourceLocator;
 
+	private final Class<?> @Nullable [] scriptInterfaces;
+
+	private @Nullable ClassLoader beanClassLoader = ClassUtils.getDefaultClassLoader();
+
+	private volatile @Nullable ScriptEngine scriptEngine;
+
 
 	/**
 	 * Create a new StandardScriptFactory for the given script source.

spring-context/src/test/java/org/springframework/beans/factory/xml/XmlBeanFactoryTestTypes.java

@@ -215,6 +215,14 @@ public DerivedConstructorDependenciesBean(TestBean spouse1, TestBean spouse2, In
 		setAge(age);
 		setName(name);
 	}
+
+	private void init() {
+		this.initialized = true;
+	}
+
+	private void destroy() {
+		this.destroyed = true;
+	}
 }
 
 

spring-context/src/test/java/org/springframework/context/aot/ReflectiveProcessorBeanFactoryInitializationAotProcessorTests.java

@@ -127,6 +127,8 @@ private void process(Class<?>... beanClasses) {
 	@SuppressWarnings("unused")
 	static class SampleTypeAnnotatedBean {
 
+		private String notManaged;
+
 		public void notManaged() {
 
 		}

spring-context/src/test/resources/org/springframework/scripting/groovy/ScriptBean.groovy

@@ -7,6 +7,8 @@ import org.springframework.scripting.ContextScriptBean
 
 class GroovyScriptBean implements ContextScriptBean, ApplicationContextAware {
 
+	private int age
+
 	@Override
 	int getAge() {
 		return this.age

spring-context/src/testFixtures/java/org/springframework/context/testfixture/context/aot/scan/reflective/ReflectiveOnField.java

@@ -21,6 +21,8 @@
 @SuppressWarnings("unused")
 public class ReflectiveOnField {
 
+	private String name;
+
 	@Reflective
 	private String description;
 

spring-core/src/test/java/org/springframework/aot/generate/PublicClass.java

@@ -19,6 +19,8 @@
 @SuppressWarnings("unused")
 public class PublicClass {
 
+	private String privateField;
+
 	String protectedField;
 
 	public PackagePrivateClass[] packagePrivateClasses;

spring-core/src/test/java/org/springframework/aot/hint/ReflectionHintsTests.java

@@ -246,6 +246,8 @@ private Consumer<TypeHint> typeWithMemberCategories(Class<?> type, MemberCategor
 	@SuppressWarnings("unused")
 	static class TestType {
 
+		private @Nullable String field;
+
 		void setName(String name) {
 
 		}

spring-core/src/test/java/org/springframework/aot/hint/annotation/ReflectiveRuntimeHintsRegistrarTests.java

@@ -167,6 +167,8 @@ private void process(Class<?> beanClass) {
 	@SuppressWarnings("unused")
 	static class SampleTypeAnnotatedBean {
 
+		private String notManaged;
+
 		public void notManaged() {
 		}
 	}

spring-core/src/test/java/org/springframework/aot/hint/predicate/ReflectionHintsPredicatesTests.java

@@ -447,6 +447,8 @@ private void assertPredicateDoesNotMatch(Predicate<RuntimeHints> predicate) {
 	@SuppressWarnings("unused")
 	static class SampleClass {
 
+		private String privateField;
+
 		public String publicField;
 
 		public SampleClass() {

spring-core/src/test/java/org/springframework/core/BridgeMethodResolverTests.java

@@ -802,6 +802,8 @@ public static class GenericBroadcasterImpl implements Broadcaster {
 	public abstract static class GenericEventBroadcasterImpl<T extends Event>
 			extends GenericBroadcasterImpl implements EventBroadcaster {
 
+		private Class<T>[] subscribingEvents;
+
 		private Channel<T> channel;
 
 		/**

spring-expression/src/test/java/org/springframework/expression/spel/testresources/Inventor.java

@@ -37,6 +37,7 @@ public class Inventor {
 	public String publicName;
 	private PlaceOfBirth placeOfBirth;
 	private Date birthdate;
+	private int sinNumber;
 	private String nationality;
 	private String[] inventions;
 	public String randomField;

spring-oxm/src/test/java/org/springframework/oxm/jaxb/Jaxb2MarshallerTests.java

@@ -377,11 +377,15 @@ public jakarta.xml.bind.Unmarshaller createUnmarshaller() {
 	@XmlRootElement
 	@SuppressWarnings("unused")
 	public static class DummyRootElement {
+
+		private DummyType t = new DummyType();
 	}
 
 	@XmlType
 	@SuppressWarnings("unused")
 	public static class DummyType {
+
+		private String s = "Hello";
 	}
 
 	@SuppressWarnings("unused")

spring-test/src/main/java/org/springframework/test/web/servlet/DefaultMvcResult.java

@@ -48,6 +48,8 @@ class DefaultMvcResult implements MvcResult {
 
 	private @Nullable Object handler;
 
+	private HandlerInterceptor @Nullable [] interceptors;
+
 	private @Nullable ModelAndView modelAndView;
 
 	private @Nullable Exception resolvedException;

spring-webflux/src/main/java/org/springframework/web/reactive/resource/PathResourceResolver.java

@@ -42,6 +42,8 @@
  */
 public class PathResourceResolver extends AbstractResourceResolver {
 
+	private Resource @Nullable [] allowedLocations;
+
 
 	/**
 	 * By default, when a Resource is found, the path of the resolved resource is

spring-webflux/src/main/java/org/springframework/web/reactive/result/view/UrlBasedViewResolver.java

@@ -80,6 +80,8 @@ public class UrlBasedViewResolver extends ViewResolverSupport
 
 	private String suffix = "";
 
+	private String @Nullable [] viewNames;
+
 	private Function<String, RedirectView> redirectViewProvider = RedirectView::new;
 
 	private @Nullable String requestContextAttribute;

spring-webmvc/src/main/java/org/springframework/web/servlet/i18n/LocaleChangeInterceptor.java

@@ -52,6 +52,8 @@ public class LocaleChangeInterceptor implements HandlerInterceptor {
 
 	private String paramName = DEFAULT_PARAM_NAME;
 
+	private String @Nullable [] httpMethods;
+
 	private boolean ignoreInvalidLocale = false;
 
 

spring-webmvc/src/main/java/org/springframework/web/servlet/resource/PathResourceResolver.java

@@ -54,6 +54,8 @@
  */
 public class PathResourceResolver extends AbstractResourceResolver {
 
+	private Resource @Nullable [] allowedLocations;
+
 	private final Map<Resource, Charset> locationCharsets = new HashMap<>(4);
 
 	private @Nullable UrlPathHelper urlPathHelper;

spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandler.java

@@ -53,6 +53,7 @@
 import org.springframework.util.StringUtils;
 import org.springframework.util.StringValueResolver;
 import org.springframework.web.HttpRequestHandler;
+import org.springframework.web.accept.ContentNegotiationManager;
 import org.springframework.web.context.request.ServletWebRequest;
 import org.springframework.web.context.support.ServletContextResource;
 import org.springframework.web.cors.CorsConfiguration;
@@ -122,6 +123,8 @@ public class ResourceHttpRequestHandler extends WebContentGenerator
 
 	private @Nullable ResourceRegionHttpMessageConverter resourceRegionHttpMessageConverter;
 
+	private @Nullable ContentNegotiationManager contentNegotiationManager;
+
 	private final Map<String, MediaType> mediaTypes = new HashMap<>(4);
 
 	private @Nullable CorsConfiguration corsConfiguration;

spring-webmvc/src/main/java/org/springframework/web/servlet/view/RedirectView.java

@@ -103,6 +103,8 @@ public class RedirectView extends AbstractUrlBasedView implements SmartView {
 
 	private boolean propagateQueryParams = false;
 
+	private String @Nullable [] hosts;
+
 
 	/**
 	 * Constructor for use as a bean.

spring-webmvc/src/main/java/org/springframework/web/servlet/view/UrlBasedViewResolver.java

@@ -116,6 +116,8 @@ public class UrlBasedViewResolver extends AbstractCachingViewResolver implements
 
 	private boolean redirectHttp10Compatible = true;
 
+	private String @Nullable [] redirectHosts;
+
 	private @Nullable String requestContextAttribute;
 
 	/** Map of static attributes, keyed by attribute name (String). */
@@ -125,6 +127,8 @@ public class UrlBasedViewResolver extends AbstractCachingViewResolver implements
 
 	private @Nullable Boolean exposeContextBeansAsAttributes;
 
+	private String @Nullable [] exposedContextBeanNames;
+
 	private String @Nullable [] viewNames;
 
 	private int order = Ordered.LOWEST_PRECEDENCE;

spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/SockJsClient.java

@@ -72,6 +72,8 @@ public class SockJsClient implements WebSocketClient, Lifecycle {
 
 	private final List<Transport> transports;
 
+	private String @Nullable [] httpHeaderNames;
+
 	private InfoReceiver infoReceiver;
 
 	private @Nullable SockJsMessageCodec messageCodec;

src/checkstyle/checkstyle.xml

@@ -87,7 +87,7 @@
 			<property name="names" value="logger"/>
 		</module>
 		<module name="com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck"/>
-		<!--		<module name="FinalLocalVariable"/>-->
+
 		<!-- Imports -->
 		<module name="AvoidStarImport"/>
 		<module name="UnusedImports"/>