Minor update

Author: stevapple

Sources/PackageLoading/ManifestLoader.swift

@@ -290,28 +290,26 @@ public final class ManifestLoader: ManifestLoaderProtocol {
         // We might have some non-fatal output (warnings/notes) from the compiler even when
         // we were able to parse the manifest successfully.
         if let compilerOutput = result.compilerOutput {
-            // FIXME: Isn't the judgement too naive?
+            // FIXME: Isn't the strategy too naive?
             var outputSeverity: Basics.Diagnostic.Severity = .warning
-            #if os(Windows)
-            // Filter out link.exe note when creating manifest executable.
+#if os(Windows)
+            // Filter out `LINK` note for creating manifest executable.
             if let compiledManifestName = result.compiledManifestFile?.basenameWithoutExt,
                !compilerOutput.contains(where: \.isNewline) {
                 if compilerOutput.contains("\(compiledManifestName).lib") && compilerOutput.contains("\(compiledManifestName).exp") {
                     outputSeverity = .debug
                 }
             }
-            #endif
-            if !compilerOutput.isEmpty {
-                let metadata = result.diagnosticFile.map { diagnosticFile -> ObservabilityMetadata in
-                    var metadata = ObservabilityMetadata()
-                    metadata.manifestLoadingDiagnosticFile = diagnosticFile
-                    return metadata
-                }
-                observabilityScope.emit(severity: outputSeverity, message: compilerOutput, metadata: metadata)
-
-                // FIXME: (diagnostics) deprecate in favor of the metadata version ^^ when transitioning manifest loader to Observability APIs
-                //observabilityScope.emit(.warning(ManifestLoadingDiagnostic(output: compilerOutput, diagnosticFile: result.diagnosticFile)))
+#endif
+            let metadata = result.diagnosticFile.map { diagnosticFile -> ObservabilityMetadata in
+                var metadata = ObservabilityMetadata()
+                metadata.manifestLoadingDiagnosticFile = diagnosticFile
+                return metadata
             }
+            observabilityScope.emit(severity: outputSeverity, message: compilerOutput, metadata: metadata)
+
+            // FIXME: (diagnostics) deprecate in favor of the metadata version ^^ when transitioning manifest loader to Observability APIs
+            //observabilityScope.emit(.warning(ManifestLoadingDiagnostic(output: compilerOutput, diagnosticFile: result.diagnosticFile)))
         }
 
         return try ManifestJSONParser.parse(