Skip to content

taco: ensure assembly is included in timing for all benchmarks #8

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
rohany opened this issue Mar 9, 2021 · 3 comments
Open

taco: ensure assembly is included in timing for all benchmarks #8

rohany opened this issue Mar 9, 2021 · 3 comments
Labels
final-check Should be checked before running final benchmarks

Comments

@rohany
Copy link
Collaborator

rohany commented Mar 9, 2021

Should the call to assemble() be included in benchmark timing @stephenchouca ?

@stephenchouca
Copy link
Collaborator

For comparisons against other Python libraries, I think it'd make sense to include the assembly time when benchmarking so that the comparison is more apples-to-apples, particularly since assembly can take a significant amount of time when the output is sparse. (Note though that assembly time can be significantly reduced if it is done with the compute step using a fused kernel. With the C++ API at least, you should be able to tell TACO to generate code that simultaneously assembles and computes the output by invoking TensorBase::setAssembleWhileCompute(true) before invoking compile.)

@rohany rohany changed the title benchmark timing inclusion taco: ensure assembly is included in timing for all benchmarks Mar 9, 2021
@rohany
Copy link
Collaborator Author

rohany commented Mar 9, 2021

If setAssembleWhileCompute(true) is used, then does assemble even need to be called before compute?

@stephenchouca
Copy link
Collaborator

If setAssembleWhileCompute(true) is used, then does assemble even need to be called before compute?

You shouldn't have to call assemble in that case.

@rohany rohany added the final-check Should be checked before running final benchmarks label Mar 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
final-check Should be checked before running final benchmarks
Projects
None yet
Development

No branches or pull requests

2 participants