Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

twhin: translation embeddings not being added for negative examples #146

Open
ksanjeevan opened this issue Jul 16, 2024 · 0 comments
Open

twhin: translation embeddings not being added for negative examples #146

ksanjeevan opened this issue Jul 16, 2024 · 0 comments

Comments

@ksanjeevan
Copy link

how come only the real edges get the lhs + translation? translated = x[:, 1, :] + trans_embs occurs before the negative examples are generated but translated is not used in the for loop.

the-algorithm-ml/projects/twhin/models/models.py

Line 54 in b852108

translated = x[:, 1, :] + trans_embs

@ksanjeevan ksanjeevan changed the title translation embedding not being sum for negative examples twhin: translation embeddings not being added for negative examples Jul 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ksanjeevan