Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Some classes are defined more than once in the same file #23

Open
robvdl opened this issue Mar 31, 2023 · 1 comment
Open

Some classes are defined more than once in the same file #23

robvdl opened this issue Mar 31, 2023 · 1 comment

Comments

@robvdl
Copy link

robvdl commented Mar 31, 2023

I think in each case the second definition overwrites the initial definition??? at least that is what I would expect.

projects/home/recap/models/config.py

BatchNormConfig is defined twice
DropoutConfig is defined twice
MlpConfig is defined twice

projects/home/recap/embedding/config.py

SmallEmbeddingBagConfig is defined twice

projects/home/recap/model/entrypoint.py

We have two imports stomping eachother out:

from tml.projects.home.recap.model import config as model_config_mod
import tml.projects.home.recap.model.config as model_config_mod
@robvdl
Copy link
Author

robvdl commented Mar 31, 2023

On the topic of imports, I do see a few unused imports, but that would be a patch of it's own.

I don't know if any of the imports are required as an import side-effect, one would hope not.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant