Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extra space, no name? #4

Open
runeimp opened this issue Jul 22, 2020 · 2 comments
Open

Extra space, no name? #4

runeimp opened this issue Jul 22, 2020 · 2 comments

Comments

@runeimp
Copy link

runeimp commented Jul 22, 2020

I was just trying your dataurl command line tool and the output of encoding an HTML file was data:text/html; charset=utf-8;base64,... instead of data:text/html;charset=utf-8;base64,.... I'm guessing the tool is intending to put name=index.html; where the space is before charset. But is failing for some reason.

@runeimp
Copy link
Author

runeimp commented Oct 8, 2020

Any chance of this getting looked at? It's been over two months since this issue was posted and it's the only open issue in the repo. An acknowledgement that this was seen and your currently too busy to look into it would be fine.

@vincent-petithory
Copy link
Owner

@runeimp The space actually comes from mime.TypeByExtension() .
There is currently no behavior to add the name parameter when encoding a file. That's something that could be done easily though.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants