Skip to content

perf(RouterView): avoid parent rerenders when possible #2082

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

posva
Copy link
Member

@posva posva commented Dec 15, 2023

Close #1701

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 1191594
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/657c544dce062d0008af5cae

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (e978eb8) to head (b514499).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2082   +/-   ##
=======================================
  Coverage   97.28%   97.29%           
=======================================
  Files          26       26           
  Lines        6077     6090   +13     
  Branches      836      836           
=======================================
+ Hits         5912     5925   +13     
  Misses        162      162           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Narretz
Copy link

Narretz commented Oct 16, 2024

Hi @posva is this still relevant? Perf fixes are always good and I wonder if this fixes a bug I'm seeing ...

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit b514499
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/6734899965314d0008004132

Copy link

pkg-pr-new bot commented Oct 29, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/vue-router@2082

commit: b514499

@posva
Copy link
Member Author

posva commented Oct 29, 2024

@Narretz can you try using the pkg-pr published version?

@Narretz
Copy link

Narretz commented Dec 2, 2024

@posva my problem was actually solved in a vue 3.5+ update

@Narretz
Copy link

Narretz commented Mar 22, 2025

Hi @posva this has actually become relevant (to me) again, and as you can see from #1701, devs are still experiencing this as a problem and reporting it. I tested my case with the MR build and it fixes it.. So can this be merged and released? I guess there's a chance that some apps actually rely on the re-render behavior by now, but it still feels like a bug/unexpected behavior to me.

@Narretz
Copy link

Narretz commented Mar 31, 2025

Hi @posva can you give this another thought/look? See my comment above

@posva posva moved this from 🆕 Triaging to 💬 In discussion in Vue Router Roadmap Mar 31, 2025
@posva
Copy link
Member Author

posva commented Mar 31, 2025

This still requires more testing in different scenarios with Keep Alive, Transition, and Suspense to ensure everything keeps working. I haven't had the time to test all the combinations yet. There are other pending comments in the named issue. I will eventually get back to it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: 💬 In discussion
Development

Successfully merging this pull request may close these issues.

View Component unnecessarily updates when child route changes
3 participants