-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
perf(RouterView): avoid parent rerenders when possible #2082
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vue-router canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2082 +/- ##
=======================================
Coverage 97.28% 97.29%
=======================================
Files 26 26
Lines 6077 6090 +13
Branches 836 836
=======================================
+ Hits 5912 5925 +13
Misses 162 162
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Hi @posva is this still relevant? Perf fixes are always good and I wonder if this fixes a bug I'm seeing ... |
✅ Deploy Preview for vue-router canceled.
|
commit: |
@Narretz can you try using the pkg-pr published version? |
@posva my problem was actually solved in a vue 3.5+ update |
Hi @posva this has actually become relevant (to me) again, and as you can see from #1701, devs are still experiencing this as a problem and reporting it. I tested my case with the MR build and it fixes it.. So can this be merged and released? I guess there's a chance that some apps actually rely on the re-render behavior by now, but it still feels like a bug/unexpected behavior to me. |
Hi @posva can you give this another thought/look? See my comment above |
This still requires more testing in different scenarios with Keep Alive, Transition, and Suspense to ensure everything keeps working. I haven't had the time to test all the combinations yet. There are other pending comments in the named issue. I will eventually get back to it. |
Close #1701