You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customizable GamePlay Time: I have modified the "Choose GamePlay Time" section to allow users to select any time duration between 30 seconds and 5 minutes. This enhancement provides users with more flexibility in choosing their preferred game duration.
Updated Game Logic: To accommodate the change in customizable time duration, I have updated the game logic (main.js under assets/) to ensure that the selected time is reflected accurately in the gameplay. This includes adjusting time tracking.
Maintained Responsiveness: I've taken care to ensure that the game remains responsive across different devices and screen sizes. The changes made to the "Choose GamePlay Time" section and the overall game interface should adapt well to various screen dimensions.
Type of change📄
New feature (non-breaking change which adds functionality)
How this has been tested✅
I have applied the changes and tested them out in my local machine. I have played the game using different time frames, and it starts with, pauses, ends and plays out in expected manner (the expected time frame and duration). I have also seen to it so that the responsiveness is not compromised.
Additional notes
The main chnges are the files : main.html, main.css and main.js under assets/ folder and in the README.md file to reflect the new display for the "Choose GamePlay Time Box".
Checklist✅
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added demonstration in the form of GIF/video file
When we are using the slider for changing the time while choosing, the time change should be visible while sliding the slider @SoumyadevSaha Pls work on it
When we are using the slider for changing the time while choosing, the time change should be visible while sliding the slider @SoumyadevSaha Pls work on it
fixed : the time change is now getting reflected in real time while sliding the slider. Pls do check @Rakesh9100 .
Completed 🥳PR successfully merged and issue resolved on completionslop3.0SLoP 3.0 Open Source Program
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rakesh9100
added
Completed 🥳
Fixes Issue🛠️
Closes #132
Description👨💻
Aplied Changes
Customizable GamePlay Time: I have modified the "Choose GamePlay Time" section to allow users to select any time duration between 30 seconds and 5 minutes. This enhancement provides users with more flexibility in choosing their preferred game duration.
Updated Game Logic: To accommodate the change in customizable time duration, I have updated the game logic (main.js under assets/) to ensure that the selected time is reflected accurately in the gameplay. This includes adjusting time tracking.
Maintained Responsiveness: I've taken care to ensure that the game remains responsive across different devices and screen sizes. The changes made to the "Choose GamePlay Time" section and the overall game interface should adapt well to various screen dimensions.
Type of change📄
How this has been tested✅
I have applied the changes and tested them out in my local machine. I have played the game using different time frames, and it starts with, pauses, ends and plays out in expected manner (the expected time frame and duration). I have also seen to it so that the responsiveness is not compromised.
Additional notes
The main chnges are the files : main.html, main.css and main.js under assets/ folder and in the README.md file to reflect the new display for the "Choose GamePlay Time Box".
Checklist✅
Screenshots/GIF📷