Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update default path of setup to use the new directory paths in build … #1425

Merged

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Feb 24, 2021

A recent change caused the setup.py running in a clean checkout to fail unless either RAFT_PATH or CUGRAPH_BUILD_PATH were set. These are typically set if you run the build scripts, but if you try running the build steps individually by hand the script would fail unless you set one of these environment variables correctly.

This PR fixes the default path (if neither environment variable is specified) to construct the proper location for looking up raft.

Closes #1428

@ChuckHastings ChuckHastings requested a review from a team as a code owner February 24, 2021 16:36
@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Feb 24, 2021
@BradReesWork BradReesWork added this to the 0.19 milestone Mar 1, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7974502 into rapidsai:branch-0.19 Mar 3, 2021
@ChuckHastings ChuckHastings deleted the bug_clean_setup_fails branch July 28, 2021 19:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Building python doesn't work unless you specify environment variables
3 participants