Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Compilation progress indicator #39

Closed
enumag opened this issue Aug 5, 2019 · 4 comments
Closed

Compilation progress indicator #39

enumag opened this issue Aug 5, 2019 · 4 comments
Assignees
Labels
backport Syncing a modification across all arcs enhancement New feature or request

Comments

@enumag
Copy link
Member

enumag commented Aug 5, 2019

The vanilla version of Minagoroshi comes with a nice new feature of showing the scripts compilation progress on startup instead od just a blackscreen like the previous chapters.

Try to backport that into the previous chapters.

@IdealPersona @TellowKrinkle @voodoochiledev

@enumag enumag added the enhancement New feature or request label Aug 5, 2019
@enumag enumag assigned TellowKrinkle and ghost Aug 5, 2019
@ghost
Copy link

ghost commented Aug 20, 2019

I'm getting a lot of these exceptions when firing up the game and i also got some in between each script compile when running the game for the first time, so i'm thinking this is related. Not sure if it amounts to any significant issue or just log noise but noting here for future reference.

NullReferenceException: Object reference not set to an instance of an object
  at Assets.Scripts.UI.MainUIController.OnGUI () [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

NullReferenceException: Object reference not set to an instance of an object
  at Assets.Scripts.UI.MainUIController.OnGUI () [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

NullReferenceException: Object reference not set to an instance of an object
  at Assets.Scripts.UI.MainUIController.OnGUI () [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

NullReferenceException: Object reference not set to an instance of an object
  at Assets.Scripts.UI.MainUIController.OnGUI () [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

NullReferenceException: Object reference not set to an instance of an object
  at Assets.Scripts.UI.MainUIController.OnGUI () [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

NullReferenceException: Object reference not set to an instance of an object
  at Assets.Scripts.UI.MainUIController.OnGUI () [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

@TellowKrinkle
Copy link
Member

Is this in a backport attempt?

@ghost
Copy link

ghost commented Aug 20, 2019

nah this is on mina

@ghost ghost added the backport Syncing a modification across all arcs label Aug 27, 2019
@drojf
Copy link
Contributor

drojf commented Sep 30, 2022

I've backported the compilation indicator to chapters 1-6, should now be live on all those chapters.

I've just used the "Toaster" (the little mod notification that appears at the top of the screen), because on previous chapters the text object on the bottom right hand corner doesn't exist.

See here for more details: #88

@drojf drojf closed this as completed Sep 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport Syncing a modification across all arcs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants