Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add/Remove Individual Filter Items #7

Open
0916dhkim opened this issue Oct 17, 2022 · 3 comments
Open

Add/Remove Individual Filter Items #7

0916dhkim opened this issue Oct 17, 2022 · 3 comments
Assignees
@itsyurika
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed scope:frontend Front-end issue

Comments

@0916dhkim
Copy link
Owner

Current Behavior

By default, all audio features are editable, and users cannot remove any filters.
image

https://github.com/0916dhkim/spotify-filter/blob/72e443ccc69cda18fcf9ad9eed24adc3dd1e8a3f/app/src/pages/Home/EditorForm/EditingStage.tsx#L32-L41

Desired Behavior

Users should be able to select which audio features to filter by. A dropdown menu like Notion database filter UI:
image
@0916dhkim 0916dhkim added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers scope:frontend Front-end issue hacktoberfest labels Oct 17, 2022
@0916dhkim
Copy link
Owner Author

Alternative

Because adding/deleting each filter requires more user effort, we can make each filter toggleable.
Hide the min/max input elements by default and make them visible on label click.

@itsyurika
Copy link

I'll try and give it a go...!

@0916dhkim
Copy link
Owner Author

@itsyurika It's all yours 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@itsyurika itsyurika

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed scope:frontend Front-end issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0916dhkim @itsyurika