Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Why the windows version was not merged to Electron? #33

Open
wdanilo opened this issue Mar 5, 2020 · 6 comments
Open

Why the windows version was not merged to Electron? #33

wdanilo opened this issue Mar 5, 2020 · 6 comments

Comments

@wdanilo
Copy link

wdanilo commented Mar 5, 2020

Hi! This is amazing. Lack of Windows support in Electron is so sad having this solution. Would you be so nice and tell more about why it was not merged / if there are any plans of doing it ?

@Toby56
Copy link

Toby56 commented Mar 29, 2020

Probably because it's kindof a hack and has some issues.

@bennymeg
Copy link

bennymeg commented Jul 3, 2020

It might be possible to implement it properly with NodeRT and this blur code example or this acrylic code example (win 10 only).

@Gum-Joe
Copy link

Gum-Joe commented Jul 14, 2020

According to this https://docs.microsoft.com/en-us/windows/win32/apiindex/uwp-apis-callable-from-a-classic-desktop-app, APIs must have the DualApiPartition attribute to be called outside of UWP, which https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.media.acrylicbrush?view=winrt-19041 does not have. It seems to call it you need a "package identity" (https://docs.microsoft.com/en-us/windows/win32/apiindex/uwp-apis-callable-from-a-classic-desktop-app).

This could be of use: https://blogs.windows.com/windowsdeveloper/2019/10/29/identity-registration-and-activation-of-non-packaged-win32-apps/

Also there's WinUI 3....

@bennymeg
Copy link

You are right, the AcrylicBrush do not has DualApiPartition attribute, but the CompositionEffectBrush (for blurring) has.

@danielehrhardt
Copy link

Did someone get it to work?

@drunkwinter
Copy link

Fixed in my fork along with a cleanup, package updates and improvements. https://github.com/DrunkWinter/electron-vibrancy

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants