This repository has been archived by the owner on May 10, 2024. It is now read-only.
AlpacaStream support for ArrayBuffer formatted binary messages #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. 🙂 |
|
Now available in the latest public version |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
In a React Native project, I ran into a JSON.parse error on instantiating an AlpacaStream because (in this context) the default binary data type for WebSocket seems to be ArrayBuffer rather than Blob. This might be fixable by instead setting
this.connection.binaryType = 'blob';right after instantiating the WebSocket, but I offer this addition for any use cases where ArrayBuffer might be needed.For reference, the decoding of the ArrayBuffer was taken from here.