Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Script doesn't read last turn #166

Closed
FireZura opened this issue Feb 6, 2019 · 24 comments
Closed

Script doesn't read last turn #166

FireZura opened this issue Feb 6, 2019 · 24 comments

Comments

@FireZura
Copy link

FireZura commented Feb 6, 2019

Hi.
I'm trying to farm door with this setup "cl1defghi5,#,6,#,4". Everything works except the last turn. Whatever i put there, it doesn't execute and goes into auto mode. I still finish the quest, but i would like to know what wrong for the futur.

Thank you

@potchy
Copy link
Collaborator

potchy commented Feb 6, 2019

I couldn't reproduce your problem. That command list is working normally for me.
What server do you play in? EN, JP, TW?

@FireZura
Copy link
Author

FireZura commented Feb 6, 2019

EN.
On a samsung galaxy S7, android 8.0 if that helps.

@FireZura
Copy link
Author

FireZura commented Feb 7, 2019

FGO_EN_REGULAR.zip

@potchy
Copy link
Collaborator

potchy commented Feb 7, 2019

Still can't reproduce. I'm farming Valentine's and it's working great.
#164 seems to have the same problem. Maybe one of you can share a video?

@FireZura
Copy link
Author

FireZura commented Feb 7, 2019

Sorry for the shit quality. The script makes the recorded video freeze with all the apps i tried, so i had to take it with my computer camera. And yeah, i just noticed that it changes to target to "danger", so i think it's the same problem
https://streamable.com/7q8af

@potchy
Copy link
Collaborator

potchy commented Feb 8, 2019

Get this file: autoskill.zip

Replace the one that already exists in the /modules folder. Start the script as normal.
A dialog like the one below will appear every turn. Every time it appears, take a screenshot and click OK to continue. Post all of them here when finished.

screenshot_2019-02-07-22-15-22

@FireZura
Copy link
Author

FireZura commented Feb 8, 2019

screenshot_20190208-062031_fate_go
screenshot_20190208-062147_fate_go
screenshot_20190208-062236_fate_go
screenshot_20190208-062310_fate_go

@potchy
Copy link
Collaborator

potchy commented Feb 8, 2019

@29988122
I think the script is not recognizing the stage changes. Any ideas? Q_Q

@29988122
Copy link
Owner

29988122 commented Feb 10, 2019

https://github.com/29988122/Fate-Grand-Order_Lua/blob/master/modules/battle.lua

Line 125
local currentStagePattern = Pattern(GeneralImagePath .. "_GeneratedStageCounterSnapshot.png"):similar(0.8)

The best we can get to solve @FireZura 's issue is similar 0.8 -> 0.85 or 0.9.

It indeed sometimes got it wrong, as the color of background's similar. (Waiting for Ankulua to implement transparent XD)
However, make the threshold higher would always make false-positive. (stage not changed, but script thought it changed)

Any ideas?

@potchy
Copy link
Collaborator

potchy commented Feb 10, 2019

@FireZura
Try to adjust the similarity % to 0.85 or 0.9, like @29988122 suggested. Tell us if it works.

@FireZura
Copy link
Author

Nope. I'll just remove the # between turn 2 and 3
But the script works for the event.

@potchy
Copy link
Collaborator

potchy commented Feb 10, 2019

Uh, nope what? You tried and it didn't work?

@FireZura
Copy link
Author

FireZura commented Feb 11, 2019 via email

@29988122
Copy link
Owner

It's the exp farming stage, and on my side it worked flawlessly - not saying you're wrong or what, but this is indeed weird.

Does your Ankulua have storage permission? Could be snapshot access issue.

@FireZura
Copy link
Author

screenshot_20190211-104531_ankulua
screenshot_20190211-104502_package installer

@potchy
Copy link
Collaborator

potchy commented Feb 11, 2019

Hey, if you don't mind, try this: debug.zip

Extract both folders to the same place your script is and overwrite everything that already exists.
Use the script to clear the same quest of that video you posted a few days before. Do this only once.
Now, there should be a few images in the /image_debug folder. Zip and post them here.
screenshot_2019-02-11-17-39-52

@FireZura
Copy link
Author

screenshot_20190213-102928_fate_go

@potchy
Copy link
Collaborator

potchy commented Feb 13, 2019

You probably forgot to click the "start capture" button after running AnkuLua.

@FireZura
Copy link
Author

Euh... i don't see any start capture button. Do i need the pro version ? Could you show me where it is with a screenshot ?

@potchy
Copy link
Collaborator

potchy commented Feb 14, 2019

It's this one.
Mine's in Portuguese. It says:
"AnkuLua will start capturing everything on screen.
Cancel - Start now"

This is required for Media Projection to work.

screenshot_2019-02-14-20-40-03-252_com android systemui

@iamcurseal
Copy link

iamcurseal commented Jul 8, 2019

I have the same problem too.

@TryBane
Copy link
Collaborator

TryBane commented Aug 26, 2019

@29988122 Pretty sure they have Transparency implemented? Either that or I'm completely misunderstanding something here XD

https://sikulix-2014.readthedocs.io/en/latest/pattern.html#Pattern.Pattern

https://puu.sh/E9ElG/98b831f5c7.png

@TryBane
Copy link
Collaborator

TryBane commented Aug 26, 2019

Just did this real quick using the "snapshop" that is in the JP folder on https://www.online-image-editor.com/ with the transparency wizard. Haven't tried it or anything, but utilizing this with the Pattern(""):mask("")

Turn 3 (transparent)

I think I might test this with Turn 1 on JP as well and will report back on it.

@reconman
Copy link
Collaborator

No reply from user, closing now. Also seems related to the stage counter similarity: #382 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

6 participants