Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Brave Chains (New Feature) #321

Open
chairmanxyz opened this issue Jan 17, 2020 · 1 comment
Open

Brave Chains (New Feature) #321

chairmanxyz opened this issue Jan 17, 2020 · 1 comment
Assignees

Comments

@chairmanxyz
Copy link

I see one post back from last March that says this feature was being worked on but no updates since then. Is this still something that is on the table for you guys? I think it would help farming immensely when you can rely on that extra attack damage to finish off a servant with face cards.

@TryBane
Copy link
Collaborator

TryBane commented Feb 12, 2020

I have been working on it on the side. I have an idea of how to implement it, but I have no idea if it'll be reliable enough. The issue comes from the variable that is the NPs. The image used for the NPs has a slight "glow" of sorts that can distort the face image, which may affect the scripts ability to recognize the face cards as the same Servants. And that isn't including the potential for having a Support that is the same Servant either.

I have another idea as well though, similar to how you currently provide an image for Support selection, might be able to implement the same concept for Brave Chains. Though, it'll be a bit unreliable still, to an extent...

Anyways, I was recently working on it. There was an issue I had to overcome with one of the new features I was adding, the preload np one where you can select card prior to selecting the NP. I got that feature finished but trying to make it compatible with Brave Chains was going to be annoying. But I have found a way to get it to work, so I plan to get working on it soon.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants