Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Make the script select the party automatically based on the AutoSkill_List #367

Open
kenwiel opened this issue Apr 21, 2020 · 4 comments

Comments

@kenwiel
Copy link

kenwiel commented Apr 21, 2020

I just recently updated to the most recent version and noticed that its now possible to store multiple scripts.

As an extension of this, it would be useful to select which party is assigned to each script, so for XP farming use Party1, for QP Party 2, etc.

@reconman
Copy link
Collaborator

Are you sure it's not already covered by the Autoskill_List? https://29988122.github.io/Fate-Grand-Order_Lua/#/features?id=autoskill

I'm running one script for multiple teams where I just have to select the support/skill configuration when I start the script.

@MathewSachin
Copy link
Contributor

I think they are talking about selecting the party in the game before the quest.

@reconman
Copy link
Collaborator

Aaaah, that's going to be pretty difficult. OCR is definitely not supported, like detecting whether a team called "QP" is currently on the screen. You could do an image comparison of "PARTY II", "PARTY III", and so on.

The main problems with this feature are making it robust against the lags that come from party switching, dealing with user input validation, and also being able to run the feature on all server regions.

Now, FGO CN is currently not working at all with this script because they changed much stuff and we don't have any developer playing CN. And I haven't heard of any Taiwan player since I joined the project. So we'll probably only implement it correctly for JP and EN.

@reconman reconman changed the title Assign Party to Script [Feature] Make the script select the party automatically based on the AutoSkill_List Apr 21, 2020
@forgehe
Copy link
Contributor

forgehe commented Apr 24, 2020

We could try clicking on the small party dot indicators on top instead of swiping, or clicking on the left/right buttons. But we may run into issues with different screen sizes and resolutions misclicking who knows.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants