Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add number of spells cast field #541

Open
ASTRELION opened this issue Jul 25, 2023 · 2 comments
Open

Add number of spells cast field #541

ASTRELION opened this issue Jul 25, 2023 · 2 comments

Comments

@ASTRELION
Copy link
Contributor

ASTRELION commented Jul 25, 2023

API issue: 5e-bits/5e-srd-api#361

I'd like to propose a new optional field for spells similar to damage_at_slot_level: casts_at_slot_level. casts_at_slot_level holds the value of how many times a specific spell is cast per usage.

For instance, Magic Missile can be cast 3 times, increasing by 1 for each slot level. An example field for Magic Missile would contain the following:

"casts_at_slot_level": {
  "1": 3,
  "2": 4,
  "3": 5,
  "4": 6,
  "5": 7,
  "6": 8,
  "7": 9,
  "8": 10,
  "9": 11
}

Another spell that would contain this field would be Eldritch Blast. I'm not sure the extent of spells that would need this field.

I'm not sure if there is a spell that does this, but this may also need to add casts_at_character_level if casts increases by character level and not slot level.

@ASTRELION ASTRELION changed the title Adds number of spells cast field Add number of spells cast field Jul 25, 2023
@bagelbits
Copy link
Collaborator

It might just be those two but I think it's a solid approach.

@ecshreve
Copy link
Contributor

This definitely looks reasonable to me!

Just a note in case it becomes relevant, these types of attributes (damage_at_slot_level, heals_at_level...) that map a level to a value (map[int]->int) are problematic if/when it comes to generating a GraphQL schema from our MongoDB collections. Here's an old issue where it came up in the past: 5e-bits/5e-srd-api#60 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants