You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As in my commit to the downstream fork async-openai-wasm, it's possible to remove async-convert crate. Without async-convert, we don't need to use async-trait either, which remove extra boxing. This also shrinks binary size. I would be happy to upstream this change in a PR.
The text was updated successfully, but these errors were encountered:
Also MSRV for this crate will need to change to 1.75?
Yes
I don't follow why it shrinks binary size?
This is my guess with some ground. If you cargo-expand to see the result of an impl block by #[async_trait::async_trait], you'll see some complicated code that is just for boxing, not for the application logic. By removing these auxiliary code, the binary size should be smaller.
As in my commit to the downstream fork
async-openai-wasm
, it's possible to remove async-convert crate. Without async-convert, we don't need to useasync-trait
either, which remove extra boxing. This also shrinks binary size. I would be happy to upstream this change in a PR.The text was updated successfully, but these errors were encountered: