Skip to content

Issues with version 1.0.1 release #53

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
seriouslag opened this issue Apr 10, 2024 · 4 comments
Closed

Issues with version 1.0.1 release #53

seriouslag opened this issue Apr 10, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@seriouslag
Copy link
Collaborator

seriouslag commented Apr 10, 2024

There is a broken path to the bin executable in the version 1.0.1 release.

Here openapi-react-query-codegen

The package.json bin should point to dist/cli.mjs instead of dist/cli.js

@seriouslag seriouslag assigned seriouslag and 7nohe and unassigned seriouslag Apr 10, 2024
@seriouslag seriouslag added the bug Something isn't working label Apr 10, 2024
@seriouslag seriouslag changed the title Issues with version 1.0.0 release Issues with version 1.0.1 release Apr 10, 2024
@7nohe
Copy link
Owner

7nohe commented Apr 10, 2024

The cause was that the dist/*.js files remained on my local PC.
It was resolved in issue #57. It should be ok in version 1.0.2.

@seriouslag
Copy link
Collaborator Author

The cause was that the dist/*.js files remained on my local PC.

It was resolved in issue #57. It should be ok in version 1.0.2.

Would be great if we add more testing and automate the releases via a GitHub action. If you generated a PAT from NPM and with publish writes to NPM and set it as a build secret called NPM_TOKEN I can setup the GitHub actions to publish the package. If we also want to publish to GitHub then we will need a separate token I believe called GH_TOKEN (not 100% sure if that one is needed or is already added)

@7nohe
Copy link
Owner

7nohe commented Apr 10, 2024

I have already implemented CI-based automatic releases in another project, so I'll give it a try.

@7nohe
Copy link
Owner

7nohe commented Apr 10, 2024

The automated release has now been implemented and is working well.
https://github.com/7nohe/openapi-react-query-codegen/actions/runs/8634125533/job/23668812206

@7nohe 7nohe closed this as completed Apr 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants