Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Payload undefined #10

Closed
gliide opened this issue Apr 27, 2015 · 7 comments
Closed

Payload undefined #10

gliide opened this issue Apr 27, 2015 · 7 comments
Assignees
Labels
Milestone

Comments

@gliide
Copy link

gliide commented Apr 27, 2015

Nice idea for a module, very useful -

however currently getting 'payload undefined' on the console, and a 403 response on GitHub

@Insoleet
Copy link

Insoleet commented Dec 3, 2015

Same problem

@A21z
Copy link
Owner

A21z commented Dec 3, 2015

Could you please try with branch 2.0.0? I'll release it soon but haven't tested this bug on it yet.

@Insoleet
Copy link

Insoleet commented Dec 3, 2015

On branch 2.0.0 I get the following error :

qindex-1 TypeError: object is not a function
index-1     at callbacks (/var/www/sakia-wallet.org/node-cd/src/node_modules/express/lib/router/index.js:165:11)
index-1     at param (/var/www/sakia-wallet.org/node-cd/src/node_modules/express/lib/router/index.js:139:11)
index-1     at pass (/var/www/sakia-wallet.org/node-cd/src/node_modules/express/lib/router/index.js:146:5)
index-1     at Router._dispatch (/var/www/sakia-wallet.org/node-cd/src/node_modules/express/lib/router/index.js:173:5)
index-1     at Object.router (/var/www/sakia-wallet.org/node-cd/src/node_modules/express/lib/router/index.js:33:10)
index-1     at next (/var/www/sakia-wallet.org/node-cd/src/node_modules/express/node_modules/connect/lib/proto.js:190:15)
index-1     at Object.static (/var/www/sakia-wallet.org/node-cd/src/node_modules/express/node_modules/connect/lib/middleware/static.js:56:61)
index-1     at next (/var/www/sakia-wallet.org/node-cd/src/node_modules/express/node_modules/connect/lib/proto.js:190:15)
index-1     at Object.urlencodedParser [as handle] (/var/www/sakia-wallet.org/node-cd/node_modules/body-parser/lib/types/urlencoded.js:81:44)
index-1     at next (/var/www/sakia-wallet.org/node-cd/src/node_modules/express/node_modules/connect/lib/proto.js:190:15)

@A21z
Copy link
Owner

A21z commented Dec 3, 2015

OK I'll have a look today and try to release 2.0.0

@Insoleet
Copy link

Insoleet commented Dec 3, 2015

Please note that the hook is behind a reverse proxy.

@A21z A21z mentioned this issue Dec 4, 2015
@A21z
Copy link
Owner

A21z commented Dec 4, 2015

I fixed and merged v2.0.0, it should be better now.
Note that v2.0.0 needs node > 4

@Insoleet Could you try for yourself?
Ping @gliide, sorry for the delay :/

@A21z A21z added this to the 2.0.0 milestone Dec 4, 2015
@A21z A21z self-assigned this Dec 4, 2015
@A21z A21z added the bug label Dec 4, 2015
@Insoleet
Copy link

Forgot to tell you, but its fixed ! 👍

@A21z A21z closed this as completed Dec 15, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants