Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

NewStarFromObSourcePluginTask does not close input streams under some circumstance #80

Closed
mpyat2 opened this issue Nov 21, 2020 · 0 comments · Fixed by #81
Closed

NewStarFromObSourcePluginTask does not close input streams under some circumstance #80

mpyat2 opened this issue Nov 21, 2020 · 0 comments · Fixed by #81
Assignees
@mpyat2
Labels
bug Something isn't working

Comments

@mpyat2
Copy link
Collaborator

mpyat2 commented Nov 21, 2020

NewStarFromObSourcePluginTask.java:
if 'retriever' is not set in 'configure()' method, the input stream remains open; this locks file under Windows.
'obSourcePlugin.getObservationRetriever()' may return null (for example, when parameter dialog is canceled (if it used by a plugin))
@mpyat2 mpyat2 added the bug Something isn't working label Nov 21, 2020
@mpyat2 mpyat2 self-assigned this Nov 21, 2020
@dbenn dbenn linked a pull request Nov 21, 2020 that will close this issue
Issue 80: closing input streams if no retriever returned by obSourceP… #81
Merged
@dbenn dbenn closed this as completed in #81 Nov 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mpyat2 mpyat2

Labels
bug Something isn't working
Projects
VStar Development Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 80: closing input streams if no retriever returned by obSourceP… AAVSO/VStar
1 participant
@mpyat2