Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

setSendReportsAtShutdown(false) causes reports to not be sent #382

Closed
paulpv opened this issue Feb 28, 2016 · 0 comments
Closed

setSendReportsAtShutdown(false) causes reports to not be sent #382

paulpv opened this issue Feb 28, 2016 · 0 comments

Comments

@paulpv
Copy link

paulpv commented Feb 28, 2016

(Pseudo-related: #375)

My sendReportsAtShutdown is configured to be false.
I am expecting reports to be sent at startup.
But...
https://github.com/ACRA/acra/blob/master/src/main/java/org/acra/builder/ReportExecutor.java#L178
...endApplication is being called before the only thing that I can find that approved reports: https://github.com/ACRA/acra/blob/master/src/main/java/org/acra/builder/ReportExecutor.java#L187
startSendingReports(sendOnlySilentReports, true);

Repro:

ACRA.init(this,
          new ConfigurationBuilder(this)
            .setSendReportsAtShutdown(false)
            .build(),
          true);
Object simulateCrash = null;
simulateCrash.toString();

NOTE: I was setting sendReportsAtShutdown to false because in previous versions of ACRA, crash reports would sometimes fail to sent. I will be leaving this to the default of true, but this sendReportsAtShutdown feature should either be fixed or removed. I would be OK for removing it, as long as sendReportsAtShutdown is at least as reliable as sending reports at start up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants