Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Generated id method for user facing types has become useless #438

Closed
tmadlener opened this issue Jul 3, 2023 · 0 comments · Fixed by #493
Closed

Generated id method for user facing types has become useless #438

tmadlener opened this issue Jul 3, 2023 · 0 comments · Fixed by #493
Labels
bug

Comments

@tmadlener
Copy link
Collaborator

The id method we generate for user facing object has become very hard to interpret with #412 :

podio/python/templates/macros/declarations.jinja2

Line 96 in d8294d2

unsigned int id() const { return getObjectID().collectionID * 10000000 + getObjectID().index; }

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Object::id() return an ObjectID since unsigned has become useless tmadlener/podio
1 participant
@tmadlener