Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Negative comparisons between podio::ObjectID objects are not implemented #495

Closed
jmcarcell opened this issue Oct 2, 2023 · 2 comments · Fixed by #496
Closed

Negative comparisons between podio::ObjectID objects are not implemented #495

jmcarcell opened this issue Oct 2, 2023 · 2 comments · Fixed by #496

Comments

@jmcarcell
Copy link
Member

#493 breaks cases where there is a negative comparison between podio::ObjectID(), that is id1 != id2, because podio::ObjectID doesn't implement the negative comparison operator.

I think it's fine the few cases we have and we don't need to implement the operator, but also implementing it is a one liner.
@jmcarcell jmcarcell changed the title https://github.com/AIDASoft/podio/pull/493 Negative comparisons between podio::ObjectID objects are not implemented Oct 2, 2023
@jmcarcell jmcarcell mentioned this issue Oct 2, 2023
Merged
@tmadlener
Copy link
Collaborator

Just out of curiosity. Did this break somewhere in the Key4hep stack? I thought I checked that by building a local version, but maybeI was missing some tests?

@jmcarcell
Copy link
Member Author

Yes in CEPCSW, we also build it for the nightlies

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an operator != in podio::ObjectID jmcarcell/podio
2 participants
@tmadlener @jmcarcell