Skip to content

CMake: Remove dependency on externally defined MBED_PATH variable #14385

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
rwalton-arm opened this issue Mar 5, 2021 · 3 comments
Open

CMake: Remove dependency on externally defined MBED_PATH variable #14385

rwalton-arm opened this issue Mar 5, 2021 · 3 comments

Comments

@rwalton-arm
Copy link
Contributor

rwalton-arm commented Mar 5, 2021

Description of defect

Currently we require an MBED_PATH CMake variable to be defined by the consumer in order for mbed-os to build.

It seems to be poor architecture that we require the application to define this MBED_PATH variable when mbed-os has a hard dependency on it. CMake provides several variables to automatically discover the current path, we should use them if we can. The current system leads to a non-obvious dependency on the consumer. That dependency makes building mbed-os more difficult than it should be in various cases.

If the consumer also needs to include something from mbed-os' CMake modules, e.g to run objcopy in a post build step, they should probably define that path themselves in another variable mbed-os doesn't depend on.

Target(s) affected by this defect ?

all

Toolchain(s) (name and version) displaying this defect ?

all

What version of Mbed-os are you using (tag or sha) ?

mbed-tools 7.0

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

How is this defect reproduced ?

Just look at files

@ciarmcom
Copy link
Member

ciarmcom commented Mar 5, 2021

@rwalton-arm thank you for raising this issue.Please take a look at the following comments:

What target(s) are you using?
What toolchain(s) are you using?
It would help if you could also specify the versions of any tools you are using?
How can we reproduce your issue?

NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'. This indicates to us that at least all the fields have been considered.
Please update the issue header with the missing information, the issue will not be mirrored to our internal defect tracking system or investigated until this has been fully resolved.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2021

I fixed the template, once copied internally, we can move this to CMake backlog.

@ciarmcom
Copy link
Member

ciarmcom commented Mar 8, 2021

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-3548

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants