Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature Request]: handle webp size limit properly #11439

Closed
1 task done
SLAPaper opened this issue Jun 26, 2023 · 4 comments
Closed
1 task done

[Feature Request]: handle webp size limit properly #11439

SLAPaper opened this issue Jun 26, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@SLAPaper
Copy link
Contributor

SLAPaper commented Jun 26, 2023

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

webp has a maximum size limit of 16383*16383 (reference), which might be break when running big XYZ plots, and causing an encoding error 5.

Recommended:

  1. save a scaling down version of webp
  2. fallback to another file format at original pixel

Proposed workflow

  1. configure fallback strategy in settings
  2. run a big XYZ plot so that the plot size go over 16383
  3. there will be a scaling down webp and/or a fallback jpeg/png of original size

Additional information

No response

@SLAPaper SLAPaper added the enhancement New feature or request label Jun 26, 2023
@missionfloyd
Copy link
Collaborator

Does this option work?
image

@SLAPaper
Copy link
Contributor Author

@missionfloyd
this config save a copy of scale down version, but will still save original one beforehand, so cannot avoid the encoding error

@SLAPaper
Copy link
Contributor Author

Here is my implementation, FYI:

bf31e5b

@catboxanon
Copy link
Collaborator

Resolved by #12667

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants