From 924234e58c8585bc901ea3a16774c8289b4d7f6a Mon Sep 17 00:00:00 2001 From: Jonathan Stone Date: Fri, 14 Feb 2025 07:56:41 -0800 Subject: [PATCH] Add null check in getShaderNodes This changelist adds a missing null check in getShaderNodes, handling the edge case of an invalid output string. Previously, this edge case would trigger a crash in MaterialXCore, and now it correctly generates validation warnings and proceeds. --- source/MaterialXCore/Material.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/source/MaterialXCore/Material.cpp b/source/MaterialXCore/Material.cpp index cfa4581ed6..f41aa721ff 100644 --- a/source/MaterialXCore/Material.cpp +++ b/source/MaterialXCore/Material.cpp @@ -50,7 +50,11 @@ vector getShaderNodes(NodePtr materialNode, const string& nodeType, con vector outputs; if (input->hasOutputString()) { - outputs.push_back(nodeGraph->getOutput(input->getOutputString())); + OutputPtr connectedOutput = nodeGraph->getOutput(input->getOutputString()); + if (connectedOutput) + { + outputs.push_back(connectedOutput); + } } else {