From 2e7ff3357c036f3db54ed5c404d460d24350a71f Mon Sep 17 00:00:00 2001
From: Markus Podar <markus@fischer.name>
Date: Thu, 9 Jul 2020 07:07:38 +0200
Subject: [PATCH] Embrace extendability and make all private Transport methods
 protected

While trying to fix https://github.com/wildbit/swiftmailer-postmark/pull/32 locally
by overriding the `send()` method, I realized I couldn't do this because `send()`
calls private methods I can't access.

Since the class already contains a mix of protected/private/public, I suggest to
make everything "protected by default".

For a read on the philosophy on this, I would like to suggest to read
http://fabien.potencier.org/pragmatism-over-theory-protected-vs-private.html
for inspiration.
---
 src/Postmark/Transport.php | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/Postmark/Transport.php b/src/Postmark/Transport.php
index 34be046..4acc76c 100644
--- a/src/Postmark/Transport.php
+++ b/src/Postmark/Transport.php
@@ -116,7 +116,7 @@ public function send(Swift_Mime_SimpleMessage $message, &$failedRecipients = nul
 	 * @param Swift_Mime_SimpleMessage $message
 	 * @return int
 	 */
-	private function getRecipientCount(Swift_Mime_SimpleMessage $message) {
+	protected function getRecipientCount(Swift_Mime_SimpleMessage $message) {
 	    return count(array_merge(
             (array) $message->getTo(),
             (array) $message->getCc(),
@@ -131,7 +131,7 @@ private function getRecipientCount(Swift_Mime_SimpleMessage $message) {
 	 * @param  array  $emails
 	 * @return array
 	 */
-	private function convertEmailsArray(array $emails) {
+	protected function convertEmailsArray(array $emails) {
 		$convertedEmails = array();
 		foreach ($emails as $email => $name) {
 			$convertedEmails[] = $name
@@ -150,7 +150,7 @@ private function convertEmailsArray(array $emails) {
 	 * @param  string                    $mimeType
 	 * @return Swift_Mime_MimePart
 	 */
-	private function getMIMEPart(Swift_Mime_SimpleMessage $message, $mimeType) {
+	protected function getMIMEPart(Swift_Mime_SimpleMessage $message, $mimeType) {
 		foreach ($message->getChildren() as $part) {
 			if (strpos($part->getContentType(), $mimeType) === 0 && !($part instanceof \Swift_Mime_Attachment)) {
 				return $part;
@@ -164,7 +164,7 @@ private function getMIMEPart(Swift_Mime_SimpleMessage $message, $mimeType) {
 	 * @param  Swift_Mime_SimpleMessage  $message
 	 * @return object
 	 */
-	private function getMessagePayload(Swift_Mime_SimpleMessage $message) {
+	protected function getMessagePayload(Swift_Mime_SimpleMessage $message) {
 		$payload = [];
 
 		$this->processRecipients($payload, $message);
@@ -185,7 +185,7 @@ private function getMessagePayload(Swift_Mime_SimpleMessage $message) {
 	 * @param  Swift_Mime_SimpleMessage  $message
 	 * @return object
 	 */
-	private function processRecipients(&$payload, $message) {
+	protected function processRecipients(&$payload, $message) {
 		$payload['From'] = join(',', $this->convertEmailsArray($message->getFrom()));
 		if ($to = $message->getTo()) {
             $payload['To'] = join(',', $this->convertEmailsArray($to));
@@ -211,7 +211,7 @@ private function processRecipients(&$payload, $message) {
 	 * @param  Swift_Mime_SimpleMessage  $message
 	 * @return object
 	 */
-	private function processMessageParts(&$payload, $message) {
+	protected function processMessageParts(&$payload, $message) {
 		//Get the primary message.
 		switch ($message->getContentType()) {
 			case 'text/html':
@@ -256,7 +256,7 @@ private function processMessageParts(&$payload, $message) {
 	 * @param  Swift_Mime_SimpleMessage  $message
 	 * @return object
 	 */
-	private function processHeaders(&$payload, $message) {
+	protected function processHeaders(&$payload, $message) {
 		$headers = [];
 
 		foreach ($message->getHeaders()->getAll() as $key => $value) {