Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(sync): moved logic in sync-test scripts into rust, enabling sync with a single command #430

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Oct 29, 2023

Goals

  • Run a full sync as simple as: cargo run --bin aw-sync -- sync or simply aw-sync sync.
  • Make it possible to run as a daemon, which regularly syncs on its own (started by aw-qt)

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Attention: 150 lines in your changes are missing coverage. Please review.

Comparison is base (88464b5) 73.16% compared to head (3274e20) 70.53%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   73.16%   70.53%   -2.63%     
==========================================
  Files          44       47       +3     
  Lines        2795     2902     +107     
==========================================
+ Hits         2045     2047       +2     
- Misses        750      855     +105     
Files Coverage Δ
aw-server/src/dirs.rs 80.76% <100.00%> (ø)
aw-server/src/main.rs 0.00% <0.00%> (ø)
aw-server/src/logging.rs 0.00% <0.00%> (ø)
aw-sync/src/sync.rs 47.97% <0.00%> (+4.68%) ⬆️
aw-sync/src/dirs.rs 0.00% <0.00%> (ø)
aw-sync/src/main.rs 0.00% <0.00%> (ø)
aw-sync/src/sync_wrapper.rs 0.00% <0.00%> (ø)
aw-sync/src/util.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare ErikBjare changed the title feat(sync): moved logic in test-sync-pull/push.sh scripts into rustcode, enabling easy sync with a single command feat(sync): moved logic in test-sync-pull/push.sh scripts into rust, enabling sync with a single command Oct 29, 2023
@ErikBjare ErikBjare force-pushed the dev/even-more-sync branch 2 times, most recently from e300f78 to 7120e4c Compare October 29, 2023 13:25
@ErikBjare
Copy link
Member Author

The daemon part isn't done, but not planning to work on this in the immediate future, so merging for now since it's pretty good.

@ErikBjare ErikBjare changed the title feat(sync): moved logic in test-sync-pull/push.sh scripts into rust, enabling sync with a single command feat(sync): moved logic in sync-test scripts into rust, enabling sync with a single command Oct 30, 2023
@ErikBjare ErikBjare merged commit 3ab8291 into master Oct 30, 2023
@ErikBjare ErikBjare deleted the dev/even-more-sync branch October 30, 2023 10:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant