Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: added back wmi method on Windows as fallback for admin processes #96

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Dec 23, 2023

I haven't tested this or anything, flying blind on a non-Windows machine, but shouldn't be much more than this.

Addresses regression caused by #83

Fixes #94
Fixes ActivityWatch/activitywatch#873
Fixes ActivityWatch/activitywatch#1004

@ErikBjare
Copy link
Member Author

ErikBjare commented Jan 5, 2024

As I wrote in ActivityWatch/activitywatch#1004:

Might be bold and merge this without testing it myself. Goal is to get a new beta release out that fixes this ASAP (along with another window watcher fix for macOS).

@ErikBjare ErikBjare changed the title feat(wip): added back wmi method on Windows as fallback for admin processes feat: added back wmi method on Windows as fallback for admin processes Jan 5, 2024
@ErikBjare ErikBjare merged commit 2d878c5 into master Jan 5, 2024
@ErikBjare ErikBjare deleted the dev/windows-wmi-fallback branch January 5, 2024 16:05
@vasiliy-pdk
Copy link

Thanks for the fix! 👍 I am eager to test it to fix Helldivers 2 tracking information missing ActivityWatch/activitywatch#1029

Not sure how to test it though. I found this release https://github.com/ActivityWatch/activitywatch/releases/tag/v0.12.3b16 that includes the commits from this branch but there's a warning saying that the release is broken on several platforms. I checked the freshest beta release and found no commits from this branch.

Was it reverted or there's another fix elsewhere?

@ErikBjare
Copy link
Member Author

@vasiliy-pdk Try a newer beta than v0.12.3b16.

The commit won't show up in the commit history you linked, since the change happened in a submodule. But it is included in the release notes for v0.12.3b16, which are generated including submodules.

@vasiliy-pdk
Copy link

vasiliy-pdk commented May 23, 2024

Thanks! Installed the most recent beta 12.3b.19 release and can track Helldivers 2 now.

Screenshot 2024-05-23 204731

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants