Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[SQS] Pointer usage inconsistency #327

Open
ORBAT opened this issue Jan 22, 2015 · 2 comments
Open

[SQS] Pointer usage inconsistency #327

ORBAT opened this issue Jan 22, 2015 · 2 comments

Comments

@ORBAT
Copy link

ORBAT commented Jan 22, 2015

(This is more or less a copy of goamz/goamz#62)

The use of pointers in crowdmob/sqs is a bit inconsistent: e.g. there's a func(*SQS) DeleteMessage(*Message), but messages are handed to the user as []Message, Error has func (err *Error) Error() but xmlErrors contains Error values etc. sqs_test.go also had the downright mysterious []Message{*(&Message{…}), …} construct where the pointer is immediately dereferenced.

I made pointer usage more consistent (see here), and while I was at it I cleaned up DeleteMessageBatch so it doesn't do completely unnecessary allocation of a map and slice. I can turn this into a PR if needed, and any comments are welcome.

@ORBAT
Copy link
Author

ORBAT commented Jan 26, 2015

Turns out there's a lot more wrong with the SQS package than just a few pointer inconsistencies (requests&responses not being up to spec, V2/V4 signature craziness), so this issue is more or less cosmetic

@alimoeeny
Copy link
Contributor

We still appreciate your pull requests :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants