Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

$removeparam rule with $domain= modifier does not work on MV3 extension #3127

Open
3 tasks done
Yuki2718 opened this issue Mar 4, 2025 · 2 comments
Open
3 tasks done

Comments

@Yuki2718
Copy link

Yuki2718 commented Mar 4, 2025

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard Extension version

5.0.202

Browser version

Chrome 133.0.6943.142

OS version

Windows 11

Ad Blocking

AdGuard Base filter

Privacy

AdGuard URL Tracking filter

Social

No response

Annoyances

No response

Security

No response

Other

No response

Language-specific

No response

What Tracking protection options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Enable URL Tracking Protection filter
  2. Visit (nsfw) https://doujinnomori.com/?from=sidebar
  3. See from is not removed despite a rule $removeparam=from,domain=doujinnomori.com|shinshi-manga.net|echiman.com in the filter

Expected Behavior

Not sure

Actual Behavior

Described

Screenshots

Omitted as obvious

Additional Information

See uBlockOrigin/uBOL-home#156 (comment). The easiest and safest fix will be adding alternative rules with $domain replaced with $to.

@stephenhawk8054
Copy link

I agree. Due to the nature of removeparam (interacting directly to the requested connections), I think using to with removeparam is more natural than domain, even for non-MV3 platforms.

@Yuki2718
Copy link
Author

Yuki2718 commented Mar 4, 2025

The problem is Safari does not support $to. It might possibly be converted to $domain by https://github.com/AdguardTeam/SafariConverterLib but it will need careful evaluation. Related issue: AdguardTeam/FiltersCompiler#235

@adguard-bot adguard-bot assigned maximtop and unassigned windwak3r Mar 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

5 participants