Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

$denyallow does not allow blocking documents #1809

Closed
ameshkov opened this issue Sep 28, 2023 · 2 comments
Closed

$denyallow does not allow blocking documents #1809

ameshkov opened this issue Sep 28, 2023 · 2 comments
Labels
Bug Priority: P4 Resolution: Fixed Status: Closed Version: CoreLibs v1.13

Comments

@ameshkov
Copy link
Member

This rule simply does not work: $document,denyallow=example.org
@ameshkov ameshkov added the Bug label Sep 28, 2023
@sfionov
Copy link
Member

sfionov commented Oct 9, 2023

@ameshkov It is rejected as too wide rule

@ameshkov
Copy link
Member Author

ameshkov commented Oct 9, 2023

This check should not be applied to $denyallow rules.

I guess it's time to document this "too wide" rule validation rules in the knowledge base, too many disrepancies.

@sfionov sfionov mentioned this issue Oct 15, 2023
Merged
This was referenced Oct 23, 2023
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Bug Priority: P4 Resolution: Fixed Status: Closed Version: CoreLibs v1.13
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sfionov @ameshkov @adguard-bot