Skip to content

Contribution Guidelines

Adirelle edited this page Oct 20, 2014 · 13 revisions

Pull requests

Pull requests are the preferred way of contributing. Github has a nice article about this. Be sure to read it. Gen

  • Create a dedicated branch based on latest master for your pull request.
  • Commit on this branch, or add commits by cherry-picking them.
  • Submit the pull request.

Changes

  • Do not comment code, remove it. It is Git's job to keep track of history.
  • Keep the changes to the bare minimal as possible, or make several commits.
  • In class files, do not forget to increase the revision number (the number just after the patch number).

Whitespaces

  • Use only tabulations (width 4) to indent. Do insert spaces in between tabulations.
  • Use spaces to align following items (numbers or comments).
  • Align numbers to the right; spaces between initial indent and numbers are allowed in this case.
  • Always remove trailing whitespaces.
  • Always keep an empty line at the end of the file.

Ordering

  • Order the spell by number,
  • Start by bare numbers,
  • Keep similar lines together.
Clone this wiki locally