Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve DX of currently exported chart types and also export the missing types. #401

Closed
7 tasks done
govind-srinidhi opened this issue Feb 15, 2024 · 0 comments
Closed
7 tasks done
Assignees
Labels
problem report when a problem report is created triage viability needs to be discussed

Comments

@govind-srinidhi
Copy link
Contributor

govind-srinidhi commented Feb 15, 2024

Problem description

Currently the consumer can access Lume types only by navigating the /dist folder something like @adyen/lume/dist/@types/...

  • It would create a better developer experience if the user can access the types directly from @adyen/lume instead of navigating the entire path.

  • And certain types for instance AlluvialDiagramOptions are not exported in Vue 2 version of Lume library.
    Need to go through the list of missing types and export them too.

Expected behavior

Consumers should be allowed to import Lume types directly from @adyen/lume.

Browsers

Firefox, Chrome, Safari, Microsoft Edge, Opera

Packages

  • Vue 2 (@adyen/lume)
  • Vue 3 (@adyen/lume-vue3)

Version(s)

No response

OS

Windows, Linux, Mac

Validations

@govind-srinidhi govind-srinidhi added problem report when a problem report is created triage viability needs to be discussed labels Feb 15, 2024
@govind-srinidhi govind-srinidhi self-assigned this Feb 15, 2024
@govind-srinidhi govind-srinidhi changed the title Exporting the types of chart utils/components/composables Improve DX of currently exported chart types and also export the missing types. Feb 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
problem report when a problem report is created triage viability needs to be discussed
Projects
None yet
Development

No branches or pull requests

1 participant