Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Distance calculation short-circuited by typo #1

Open
xloem opened this issue Sep 16, 2021 · 0 comments
Open

Distance calculation short-circuited by typo #1

xloem opened this issue Sep 16, 2021 · 0 comments

Comments

@xloem
Copy link

xloem commented Sep 16, 2021

This line appears to have a critical typo in it:

if nodeup is None or nodeup < 0 or nodedown is None or nodedown:

The last condition, or nodedown, will be True for all but the first index.

What's the intended behavior here?

I notice a similar check is replicated in the block below it.

Elsewhere it was tried to comment this out and replace the previous/next indices with whole object references to resolve the resulting sorting issues in example.py.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant