Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

how to keep in sync with dapp-offer-up? #4

Open
4 of 10 tasks
dckc opened this issue Jan 31, 2024 · 5 comments
Open
4 of 10 tasks

how to keep in sync with dapp-offer-up? #4

dckc opened this issue Jan 31, 2024 · 5 comments

Comments

@dckc
Copy link
Member

dckc commented Jan 31, 2024

PR #6 inherited...

But maintaining this dapp independently from dapp-offer-up means addressing these issues in both repositories:

More along those lines, not directly related to contract deployment (perhaps belongs in a separate issue)

@dckc
Copy link
Member Author

dckc commented Mar 4, 2024

#6 copied the yarn start:contract stuff from dapp-agoric-basics.

I'll re-scope this to managing the remaining duplicate work.

@dckc dckc changed the title deploy contract to local chain how to keep in sync with dapp-offer-up? Mar 4, 2024
@dckc
Copy link
Member Author

dckc commented Apr 26, 2024

Agoric/dapp-offer-up@142bf9a is another bit of dapp-offer-up that should be here.

@dckc
Copy link
Member Author

dckc commented May 8, 2024

bundle size test refinement is not in dapp-offer-up

// JSON RPC hex encoding doubles the size
t.assert(sizeInMb * 2 < 1, 'Compressed bundle is less than 0.5MB');

https://github.com/Agoric/dapp-offer-up/blob/5a3999fb8e38a6c940a8de5b7a664d994bb0e010/contract/test/test-build-proposal.js

@dckc
Copy link
Member Author

dckc commented Jul 18, 2024

@Jovonni told me an interesting idea yesterday: both of these apps could be forks of a template dap and as refinements are made to the template they can be merged into the daps

@Jovonni
Copy link

Jovonni commented Sep 11, 2024

Things we may need to figure out:

  • what repo/branch would serve as the foundational template (some dapps needs to be upgraded)
  • which parts of the code belongs in the template repo vs the child repo

This will help us figure out the git strategy, what to rebase to, etc. Might need a design doc run before the work though.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants