Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: gridItems prop #27

Merged
merged 13 commits into from
Oct 14, 2022
Merged

feat: gridItems prop #27

merged 13 commits into from
Oct 14, 2022

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Jul 5, 2017

like a grid of images

@Akryum
Copy link
Owner

Akryum commented Jul 13, 2017

Thank you for your PR! Please don't commit dist files. 😄

@ADRDev
Copy link

ADRDev commented Sep 15, 2017

What's the status on this? I have this use-case.. I've faked it for now (item height = row height/num columns). But, if the last row doesn't have enough items to fill all columns the height gets cut off.

@okwme
Copy link
Contributor Author

okwme commented Sep 16, 2017

removed dist

@okwme
Copy link
Contributor Author

okwme commented Sep 16, 2017

@ADRDev sounds like should be a new issue if/after the PR gets merged

@ADRDev
Copy link

ADRDev commented Sep 21, 2017

@okwme oh, I wasn't saying it was a bug with your fork. i was saying it's the reason why i need your feature pulled in!

Side note: I think when you removed dist the PR includes it (ie. the merge would remove dist in master).

@Akryum
Copy link
Owner

Akryum commented Oct 24, 2017

Hi there! You need to make some adjustments for me to merge this. 😄
Also, it would be great to think about ways to make this happen in variable height mode too.

@CapitaineToinon
Copy link

Can we get an update on this? I'd love to see this feature being implemented.

@heartz66
Copy link

I'm really interested in this feature.

@nachogarcia
Copy link

No news on this after 2 and a half years? Is it ever going to be supported?

@Bearfinn
Copy link

Bumped this. This is very interesting and will fit very well with my project. Are there any alternatives while waiting for this to be supported?

@fgilio
Copy link

fgilio commented May 17, 2020

Bumped this. This is very interesting and will fit very well with my project. Are there any alternatives while waiting for this to be supported?

Sure it's late, but for reference: #356

@Ktar5
Copy link

Ktar5 commented Jul 12, 2020

Would like an update on this @Akryum

@sawanm9000
Copy link

Is this still being worked on?

@mateuszdargacz
Copy link

will that be supported?

@EricRabil
Copy link

It doesn't look like this repo has been getting much attention from the maintainer. Would you guys be interested in a fork that takes in the recent PRs and keeps up with some of the bigger issues?

@seeratawan01
Copy link

Word Around by dividing the array into chunks: https://github.com/seeratawan01/Virtual-Scroll-Playground/

@Akryum Akryum changed the base branch from master to v1 October 14, 2022 16:06
@Akryum Akryum changed the title works with multiple items per row at a fixed height feat: gridItems prop Oct 14, 2022
@Akryum Akryum merged commit 6339e72 into Akryum:v1 Oct 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.