Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Manga object returned by nhentai.py doesn't contain characters or parodies #62

Open
Czevak opened this issue Jan 23, 2024 · 4 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@Czevak
Copy link

Czevak commented Jan 23, 2024

The Manga object doesn't contain character or parody variables and NHentai.get() doesn't parse them either. Can these be updated to fetch them?

@Macaroni-Biff
Copy link

I noticed that there is an active PR that addresses this issue. The PR has failed some checks, but if you're trying to get this implemented ASAP then you may be able to work off of that PR. Just note that it is NOT from the repo creator and has failed checks so it may not work "out of the box".

@AlexandreSenpai
Copy link
Owner

AlexandreSenpai commented Jan 26, 2024

Hello guys.

Enma isnt a NHentai specific library. Actually its an agnostic scrapper so we cant make the Manga entity with specific keys to bring all the nhentai features. At the current dev version 2.3.0.alpha-5 Enma brings in genres prop all the nhentai tags except for parodies and characters cuz it doesnt make much sense to be there as it doesnt fit with the genre purpose.

the alpha version can be installed using:

pip install -i https://test.pypi.org/simple/ enma==2.3.0a5

I want to release this version in this month, because it will bring some bug fixes and features.

Thanks for suggesting features and fixes. I love to read them, it helps to improve the lib much faster (〃 ̄︶ ̄)人( ̄︶ ̄〃)

@AlexandreSenpai AlexandreSenpai self-assigned this Jan 26, 2024
@AlexandreSenpai AlexandreSenpai added the enhancement New feature or request label Jan 26, 2024
@AlexandreSenpai
Copy link
Owner

Hello! Enma version 2.3.0 has been released!

pip install enma==2.3.0

@SakiSakiSakiSakiSaki
Copy link

Enma brings in genres prop all the nhentai tags except for parodies and characters cuz it doesnt make much sense to be there as it doesnt fit with the genre purpose.

Will this be a planned feature at some point? Feels like a crucial bit of data missing don't you think? But I understand your stance, because as you said, this is an provider-agonistic scrapper.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants