Don't complete an entity zoom while morphing. #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If viewer.zoomTo found itself in the middle of a morph it would crash. We now wait for the morph to complete. I couldn't think of a good unit for this because it's a race condition, but there are instructions in the linked issue on reproducing it in Sandcastle. Fixes #2680
|
Looks good to me! |
hpinkos
pushed a commit
that referenced
this pull request
Jun 2, 2015
Don't complete an entity zoom while morphing.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If viewer.zoomTo found itself in the middle of a morph it would crash. We now wait for the morph to complete. I couldn't think of a good unit for this because it's a race condition, but there are instructions in the linked issue on reproducing it in Sandcastle. Fixes #2680