Exception when using the camera inside morphComplete handler #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the scene camera at the end of a morph before raising the morph event, otherwise the camera still thinks we're morphing and throws exceptions. Fixes #2678.
|
@bagnell can you review and merge? Probably deserves a mention in CHANGES.md. |
|
@mramato Looks good to me. Can you update CHANGES.md? |
|
CHANGES is updated, I also added a few missing changes from an earlier pull request. This is ready. |
bagnell
added a commit
that referenced
this pull request
Jun 4, 2015
…ce-conditions Exception when using the camera inside morphComplete handler
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the scene camera at the end of a morph before raising the morph event, otherwise the camera still thinks we're morphing and throws exceptions.
Fixes #2678.
@bagnell I assume what I'm doing here is okay, but let me know if it's the wrong approach.